D9803: Apply some C++11 niceties, styling consistency

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Jan 12 00:50:07 UTC 2018


apol added inline comments.

INLINE COMMENTS

> Kanedias wrote in plasmadesktoptheme.cpp:160
> I didn't quite get it, you mean we can write `for (auto state : { QPalette::Active, QPalette::Inactive, QPalette::Disabled })` to get rid of allocation of `states` array?

Yes, or `static const auto states = { QPalette::Active, QPalette::Inactive, QPalette::Disabled };`
Shouldn't be much of a difference.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D9803

To: Kanedias, mart
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180112/94d5d898/attachment.html>


More information about the Plasma-devel mailing list