D9601: Make media controls configurable

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  I think the change is needed and makes sense.
  
  There's a logic bug though.

INLINE COMMENTS

> kcm.cpp:136
> +        if (md.isValid()) {
> +            const QStringList capabilities = KPluginMetaData::readStringList(md.rawData(), QStringLiteral("X-Plasma-Capabilities"));
> +            mediaControlsSupported = capabilities.contains(QLatin1String("MediaControlsOnLockScreen"));

This won't work.

Kpacakges don't inherit metadata, so I think if you changed to breeze-dark you'd get the controls but lose the ability to turn them off.
You can't assume that authors should copy metadata, as we existing packages out there.

But also you can't just iterate through parent packages metadata either, what if someone inherited Breeze but then *did* replace the lockscreen.

I can't think of anything that'll work, other than just adding "if available" to the config label and skipping this.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9601

To: broulik, #plasma, #vdg, graesslin, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180104/5d7701d3/attachment.html>