<table><tr><td style="">davidedmundson requested changes to this revision.<br />davidedmundson added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9601" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>I think the change is needed and makes sense.</p>

<p>There's a logic bug though.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9601#inline-43771" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcm.cpp:136</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">md</span><span class="p">.</span><span class="n">isValid</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">const</span> <span class="n">QStringList</span> <span class="n">capabilities</span> <span style="color: #aa2211">=</span> <span class="n">KPluginMetaData</span><span style="color: #aa2211">::</span><span class="n">readStringList</span><span class="p">(</span><span class="n">md</span><span class="p">.</span><span class="n">rawData</span><span class="p">(),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"X-Plasma-Capabilities"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">mediaControlsSupported</span> <span style="color: #aa2211">=</span> <span class="n">capabilities</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span style="color: #766510">"MediaControlsOnLockScreen"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This won't work.</p>

<p style="padding: 0; margin: 8px;">Kpacakges don't inherit metadata, so I think if you changed to breeze-dark you'd get the controls but lose the ability to turn them off.<br />
You can't assume that authors should copy metadata, as we existing packages out there.</p>

<p style="padding: 0; margin: 8px;">But also you can't just iterate through parent packages metadata either, what if someone inherited Breeze but then *did* replace the lockscreen.</p>

<p style="padding: 0; margin: 8px;">I can't think of anything that'll work, other than just adding "if available" to the config label and skipping this.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R133 KScreenLocker</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9601" rel="noreferrer">https://phabricator.kde.org/D9601</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, VDG, graesslin, davidedmundson<br /><strong>Cc: </strong>davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>