D9601: Make media controls configurable

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcm.cpp:136
> This won't work.
> 
> Kpacakges don't inherit metadata, so I think if you changed to breeze-dark you'd get the controls but lose the ability to turn them off.
> You can't assume that authors should copy metadata, as we existing packages out there.
> 
> But also you can't just iterate through parent packages metadata either, what if someone inherited Breeze but then *did* replace the lockscreen.
> 
> I can't think of anything that'll work, other than just adding "if available" to the config label and skipping this.

maybe we need a lnf specific config module? It's not the first feature where I would say that this actually doesn't belong into kscreenlocker kcm as it's specific to the theme.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9601

To: broulik, #plasma, #vdg, graesslin, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180104/14d3d545/attachment-0001.html>