D10668: Fix PowerDevil shortcuts migration

Christoph Feck noreply at phabricator.kde.org
Mon Feb 19 21:48:18 UTC 2018


cfeck added a comment.


  Regarding the comments, I prefer a space after '//' for better readability.

INLINE COMMENTS

> powerdevilapp.cpp:169
> +        });
> +        for(const QString &actionId: actionIds)
> +        {

Missing space after 'for'.

> powerdevilapp.cpp:170
> +        for(const QString &actionId: actionIds)
> +        {
> +            QAction oldAction;

Please move brace to previous line.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D10668

To: davidedmundson, #plasma
Cc: cfeck, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180219/dcfe044a/attachment-0001.html>


More information about the Plasma-devel mailing list