D10668: Fix PowerDevil shortcuts migration

Albert Astals Cid noreply at phabricator.kde.org
Mon Feb 19 23:21:57 UTC 2018


aacid added inline comments.

INLINE COMMENTS

> powerdevilapp.cpp:177
> +            KGlobalAccel::self()->setShortcut(&oldAction, QList<QKeySequence>());
> +            auto shortcuts = KGlobalAccel::self()->shortcut(&oldAction);
> +            KGlobalAccel::self()->removeAllShortcuts(&oldAction);

Won't this return QList<QKeySequence>() since you've set it on the line just before?

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D10668

To: davidedmundson, #plasma
Cc: aacid, cfeck, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180219/910d262f/attachment.html>


More information about the Plasma-devel mailing list