D10315: [Notifications] Fix grouping

Mon Feb 5 08:35:51 UTC 2018

fvogt added inline comments.

INLINE COMMENTS

> notificationsengine.cpp:266
>      const int WORD_PER_MINUTE = 250;
> -    int count = summary.length() + body.length();
> +    int count = summary.length() + (body.length() - 33); // 33 is the length of <?xml> and <html> tags
>  

I don't like magic numbers, maybe `sizeof("<?xml version="1.0"><html></html>")-1`?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10315

To: broulik, #plasma, davidedmundson, aacid, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180205/c3398010/attachment-0001.html>