<table><tr><td style="">fvogt added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10315" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10315#inline-47914" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">notificationsengine.cpp:266</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">WORD_PER_MINUTE</span> <span style="color: #aa2211">=</span> <span style="color: #601200">250</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">int</span> <span class="n">count</span> <span style="color: #aa2211">=</span> <span class="n">summary</span><span class="p">.</span><span class="n">length</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">body</span><span class="p">.</span><span class="n">length</span><span class="p">()<span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">count</span> <span style="color: #aa2211">=</span> <span class="n">summary</span><span class="p">.</span><span class="n">length</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">body</span><span class="p">.</span><span class="n">length</span><span class="p">()<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">33</span></span><span class="bright"></span><span class="p"><span class="bright">);</span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">// 33 is the length of <?xml> and <html> tags</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't like magic numbers, maybe <tt style="background: #ebebeb; font-size: 13px;">sizeof("<?xml version="1.0"><html></html>")-1</tt>?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10315" rel="noreferrer">https://phabricator.kde.org/D10315</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, davidedmundson, aacid, fvogt<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>