D10315: [Notifications] Fix grouping

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, aacid, fvogt.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Sanitize the body before doing anything else.
  Cleanup grouping logic.

TEST PLAN
  Unit test still passes
  
    notify-send "Test" "Hello"; notify-send "Test" "Hello"
  
  resulted in a single popup with "Test" summary and body
  
  > Hello
  
  
  
    notify-send "Test" "Hello"; notify-send "Test" "Darkness"
  
  resulted in a single popup with "Test" summary and body
  
  > Hello
  > Darkness
  
  (previously the notification would become empty)
  Verified that non-whitelisted tags like `<h1>` were still filtered out in both cases
  
    notify-send "Test" "Hello"; notify-send "Test2" "Hello"
  
  resulted in two separate popups. Also couldn't observe any "notification contained invalid XML" warnings on console.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10315

AFFECTED FILES
  dataengines/notifications/notificationsengine.cpp

To: broulik, #plasma, davidedmundson, aacid, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180205/415e4071/attachment.html>