D10184: Port mediawiki runner to Plasma5/Qt5

[Kai Uwe Broulik]

broulik added a comment.


  Lgtm

INLINE COMMENTS

> mediawiki.cpp:60
>      //FIXME: at the moment KIO doesn't seem to work in threads
>      d->manager = new QNetworkAccessManager( this );
>      //d->manager = new KIO::AccessManager( this );

Make sure to enable `QNetworkAccessManager` auto-redirect or else Ben will get mad at you

> mediawiki.cpp:134
>  
> -    kDebug() << "Constructed search URL" << url;
> +    qDebug() << "Constructed search URL" << url;
>  

Categorized logging, perhaps?

> mediawiki.h:74
>       */
> -    MediaWiki( QObject *parent=0 );
> -    virtual ~MediaWiki();
> +    explicit MediaWiki(QObject* parent = nullptr);
> +    ~MediaWiki() override;

Asterisk goes to variable name, `QObject *parent` (pedantic)

> plasma-runner-wikipedia.desktop:118
>  
> -X-Plasma-Args=http://en.wikipedia.org/w/api.php

Is there a chance we can make this user-configurable or perhaps have it use the current language automatically? (Just asking, it's fine if you just did a straight port)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10184

To: kossebau, broulik, jriddell, davidedmundson, sebas
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180202/4aa34361/attachment-0001.html>