<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10184" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Lgtm</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10184#inline-47429" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">mediawiki.cpp:60</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">//FIXME: at the moment KIO doesn't seem to work in threads</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">manager</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QNetworkAccessManager</span><span class="p">(</span> <span style="color: #aa4000">this</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">//d->manager = new KIO::AccessManager( this );</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Make sure to enable <tt style="background: #ebebeb; font-size: 13px;">QNetworkAccessManager</tt> auto-redirect or else Ben will get mad at you</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10184#inline-47430" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">mediawiki.cpp:134</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">k</span>Debug</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Constructed search URL"</span> <span style="color: #aa2211"><<</span> <span class="n">url</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span class="n"><span class="bright">q</span>Debug</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Constructed search URL"</span> <span style="color: #aa2211"><<</span> <span class="n">url</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Categorized logging, perhaps?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10184#inline-47427" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">mediawiki.h:74</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">MediaWiki</span><span class="p">(<span class="bright"></span></span><span class="bright"> </span><span class="n">QObject<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="n">parent<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"> </span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="n"><span class="bright">virtual</span></span><span class="bright"> </span><span style="color: #aa2211">~</span><span class="n">MediaWiki</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span class="n"><span class="bright">explicit</span></span><span class="bright"> </span><span style="color: #004012">MediaWiki</span><span class="p">(</span><span class="n">QObject<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span class="n">parent<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">nullptr</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211">~</span><span class="n">MediaWiki</span><span class="p">()<span class="bright"></span></span><span class="bright"> </span><span class="n"><span class="bright">override</span></span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Asterisk goes to variable name, <tt style="background: #ebebeb; font-size: 13px;">QObject *parent</tt> (pedantic)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10184#inline-47431" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">plasma-runner-wikipedia.desktop:118</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; color: #888888;">(Empty.)</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is there a chance we can make this user-configurable or perhaps have it use the current language automatically? (Just asking, it's fine if you just did a straight port)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10184" rel="noreferrer">https://phabricator.kde.org/D10184</a></div></div><br /><div><strong>To: </strong>kossebau, broulik, jriddell, davidedmundson, sebas<br /><strong>Cc: </strong>ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>