D10184: Port mediawiki runner to Plasma5/Qt5

[Friedrich W. H. Kossebau]

kossebau marked 2 inline comments as done.
kossebau added a comment.


  Thanks for first round of review :)

INLINE COMMENTS

> broulik wrote in mediawiki.cpp:134
> Categorized logging, perhaps?

Yes, though I plan to do this later in one concentrated go for all of kdeplasma-addons, so things will be consistent and complete.

> broulik wrote in mediawiki.h:74
> Asterisk goes to variable name, `QObject *parent` (pedantic)

Ah, too much kdevelop code done (where asterisk goes to type) :)

> broulik wrote in plasma-runner-wikipedia.desktop:118
> Is there a chance we can make this user-configurable or perhaps have it use the current language automatically? (Just asking, it's fine if you just did a straight port)

No idea yet, but i had seen the related bug report https://bugs.kde.org/show_bug.cgi?id=256019 and agree that it will be good to have.

I hope that can be covered in the planned follow-up work to improve the configuration UI to allow the user adding more mediawiki servers without having to create and install new desktop files like now.
No brain cycles yet spent on that.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10184

To: kossebau, broulik, jriddell, davidedmundson, sebas
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180206/08c24276/attachment-0001.html>