D17464: [Timer applet] Minor fixes for the applet

Alexander Kernozhitsky noreply at phabricator.kde.org
Sun Dec 9 21:48:44 GMT 2018


gepardo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gepardo requested review of this revision.

REVISION SUMMARY
  BUG: 395182
  BUG: 361025
  
  Here are the changes made:
  
  - Allow Timer widget to work well on panels, both vertical and horizontal.
  
  - Use root.digitHasChanged(); instead of main.digitChanged(); This line was changed before in https://phabricator.kde.org/D12534, but it seems that main.digitChanged(); doesn't exist also.
  
  - Use "expireTimeout" instead of "timeout", as explained in https://bugs.kde.org/show_bug.cgi?id=361025.
  
  - Increase notification time from 2s to 5s, so it's harder to miss it.

TEST PLAN
  Tried placing the timer on a panel, then tried to resize the panel. Tested on both vertical and horizontal panels.
  
  I regularly use this applet on a vertical panel without issues.

REPOSITORY
  R114 Plasma Addons

BRANCH
  timer-on-panel-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17464

AFFECTED FILES
  applets/timer/package/contents/ui/TimerDigit.qml
  applets/timer/package/contents/ui/TimerView.qml
  applets/timer/package/contents/ui/main.qml

To: gepardo
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181209/a85862f5/attachment.html>


More information about the Plasma-devel mailing list