D17464: [Timer applet] Minor fixes for the applet

[David Edmundson]

davidedmundson added a comment.


  Cool.

INLINE COMMENTS

> TimerView.qml:46
> +    states: [
> +        State {
> +            name: "verticalPanel"

what if it's neither (i.e on the desktop) ?

> TimerView.qml:53
> +                Layout.fillWidth: true
> +                Layout.maximumHeight: (2 * width / digits) * (root.showTitle ? 2 : 1)
> +                height: Layout.maximumHeight

never set size hints from current size, you're asking for binding loops.

setting it based on the implicitWith is ok

> TimerView.qml:65
> +                Layout.fillWidth: false
> +                Layout.minimumWidth: height / 2 * digits * 0.77
> +                Layout.maximumWidth: Layout.minimumWidth

where has 0.77 come from

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181209/f293f55d/attachment.html>