<table><tr><td style="">gepardo created this revision.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />gepardo requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17464">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>BUG: 395182<br />
BUG: 361025</p>
<p>Here are the changes made:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Allow Timer widget to work well on panels, both vertical and horizontal.</li>
</ul>
<ul class="remarkup-list">
<li class="remarkup-list-item">Use root.digitHasChanged(); instead of main.digitChanged(); This line was changed before in <a href="https://phabricator.kde.org/D12534" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D12534</a>, but it seems that main.digitChanged(); doesn't exist also.</li>
</ul>
<ul class="remarkup-list">
<li class="remarkup-list-item">Use "expireTimeout" instead of "timeout", as explained in <a href="https://bugs.kde.org/show_bug.cgi?id=361025" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=361025</a>.</li>
</ul>
<ul class="remarkup-list">
<li class="remarkup-list-item">Increase notification time from 2s to 5s, so it's harder to miss it.</li>
</ul></div></div><br /><div><strong>TEST PLAN</strong><div><p>Tried placing the timer on a panel, then tried to resize the panel. Tested on both vertical and horizontal panels.</p>
<p>I regularly use this applet on a vertical panel without issues.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br /><div><strong>BRANCH</strong><div><div>timer-on-panel-fix (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17464">https://phabricator.kde.org/D17464</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/timer/package/contents/ui/TimerDigit.qml<br />
applets/timer/package/contents/ui/TimerView.qml<br />
applets/timer/package/contents/ui/main.qml</div></div></div><br /><div><strong>To: </strong>gepardo<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>