D7888: Make sure OpenGL Context is valid before deleting shader
Martin Flöser
noreply at phabricator.kde.org
Wed Sep 20 15:24:36 UTC 2017
graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> scene_opengl.cpp:1191-1194
> + makeOpenGLContextCurrent();
> + delete m_lanczosFilter;
> + m_lanczosFilter = NULL;
> + doneOpenGLContextCurrent();
This combination also looks dangerous. If the context was already current it might disable it for another user inside KWin.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7888
To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170920/bb07f511/attachment.html>
More information about the Plasma-devel
mailing list