D7888: Make sure OpenGL Context is valid before deleting shader

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> graesslin wrote in scene_opengl.cpp:1191-1194
> This combination also looks dangerous. If the context was already current it might disable it for another user inside KWin.

changed is called from a timer, so we can be pretty confident that we're called mid-doing anything else, but I'm happy to do something else?

to be clear are you suggesting we:

- makeOpenGLContextCurrent() but then don't call doneOpenGLContextCurrent?

or

- set a flag, and delete it next perfectPaintWindow

or

- something completely different

Note that I have this same pattern in my BlurEffect mod I phab'd yesterday, so I'll make that follow this.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7888

To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170920/93b9fdf6/attachment.html>