D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl

[David Edmundson]

davidedmundson added a comment.


  Code does what it says but one comment
  
  1. I would move the m_mouseInterceptionWindow  code with it, that way we have RAII on that window, and less X specific things in the EffectsHandler. Logically it's grouped
  2. do we even need that fake window given we now have the XI filter?

INLINE COMMENTS

> effects.cpp:707
>      if (kwinApp()->operationMode() != Application::OperationModeX11) {
>          input()->pointer()->removeEffectsOverrideCursor();
>          return;

I know this is the wrong patch to comment on this, but it seems this wayland code is wrong.

we setEffectsOverrideCursor() when the effects count goes to 1
we should ony be removing it when it goes to 0.

i.e this should be inside m_grabbedMouseEffects.isEmpty()

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7842

To: graesslin, #kwin, #plasma
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170915/03f45829/attachment.html>