D8469: Use XDG_DATA_DIR and security fix

[Crypto Dude]

cryptodude added a comment.


  > I'm not sure the users will like what you did with encfs, but we can at least test the waters. :)
  
  Sounds good.
  
  I know for every feature you take away from users they will be a user that will complain about it. No doubt. I hope we can stand by the position that a wizard that allows a user to set up a vault that is easy to spoof or break is a broken wizard. Not a missing feature.

INLINE COMMENTS

> ivan wrote in directorypairchooserwidget.cpp:90
> What do you think about having it disabled instead of hidden?
> 
> (I'm expecting bug reports "no information about the data location" if it just gets hidden - if it is just disabled, at least people will know where it is)

I didn't consider it an issue as its just data that they would never ever interact with. People never cared where their post-it notes etc are stored.

Making it disabled will more likely be the cause of people not being able to figure out why its disabled. And they start to look for a way to enable it. Causing more confusion.

How does replacing it with a text label sound?

> ivan wrote in directorypairchooserwidget.cpp:123
> Replace this with http://doc.qt.io/qt-5/qstandardpaths.html (I think you need QStandardPaths::AppLocalDataLocation)

No, the Qt one includes the appname. So I'd get;

> ~/.local/share/kded5/

Are the Windows/Mac platforms relevant at all? If not, I'd just like to keep it the way it is.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8469

To: cryptodude, ivan, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171025/01b73d07/attachment.html>