D8469: Use XDG_DATA_DIR and security fix

[Ivan Čukić]

ivan added a comment.


  This one is almost mergeable.
  
  I'm not sure the users will like what you did with encfs, but we can at least test the waters. :)

INLINE COMMENTS

> directorypairchooserwidget.cpp:90
> +        d->ui.editDevice->setVisible(false);
> +        d->ui.labelDevice->setVisible(false);
> +    } else {

What do you think about having it disabled instead of hidden?

(I'm expecting bug reports "no information about the data location" if it just gets hidden - if it is just disabled, at least people will know where it is)

> directorypairchooserwidget.cpp:123
>  {
> -    const auto name = payload[KEY_NAME].toString();
> +    QString xdgHomeString = QFile::decodeName(qgetenv("XDG_DATA_HOME"));
> +    if (xdgHomeString.isEmpty())

Replace this with http://doc.qt.io/qt-5/qstandardpaths.html (I think you need QStandardPaths::AppLocalDataLocation)

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D8469

To: cryptodude, ivan, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171025/5d42614e/attachment.html>