D8476: qPort to new connect api + use const'ref

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> foldermodel.h:256
>          void requestRename() const;
> -        void move(int x, int y, QList<QUrl> urls);
> +        void move(int x, int y, const QList<QUrl> &urls);
>          void popupMenuAboutToShow(KIO::DropJob *dropJob, QMimeData *mimeData, int x, int y);

Did you check whether QML can cope with `const &`? The `urls` is used in an `onMove` QML handler (I recall it not handling `const *` well)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8476

To: mlaurent, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171025/a3c90e28/attachment-0001.html>