<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8476" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8476#inline-36479" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">foldermodel.h:256</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">void</span> <span style="color: #004012">requestRename</span><span class="p">()</span> <span style="color: #aa4000">const</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">void</span> <span style="color: #004012">move</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">x</span><span class="p">,</span> <span style="color: #aa4000">int</span> <span class="n">y</span><span class="p">,</span> <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">QUrl</span><span style="color: #aa2211">></span> <span class="n">urls</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">void</span> <span style="color: #004012">move</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">x</span><span class="p">,</span> <span style="color: #aa4000">int</span> <span class="n">y</span><span class="p">,</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">QUrl</span><span style="color: #aa2211">></span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">&</span></span><span class="n">urls</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">void</span> <span style="color: #004012">popupMenuAboutToShow</span><span class="p">(</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">DropJob</span> <span style="color: #aa2211">*</span><span class="n">dropJob</span><span class="p">,</span> <span class="n">QMimeData</span> <span style="color: #aa2211">*</span><span class="n">mimeData</span><span class="p">,</span> <span style="color: #aa4000">int</span> <span class="n">x</span><span class="p">,</span> <span style="color: #aa4000">int</span> <span class="n">y</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Did you check whether QML can cope with <tt style="background: #ebebeb; font-size: 13px;">const &</tt>? The <tt style="background: #ebebeb; font-size: 13px;">urls</tt> is used in an <tt style="background: #ebebeb; font-size: 13px;">onMove</tt> QML handler (I recall it not handling <tt style="background: #ebebeb; font-size: 13px;">const *</tt> well)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8476" rel="noreferrer">https://phabricator.kde.org/D8476</a></div></div><br /><div><strong>To: </strong>mlaurent, hein<br /><strong>Cc: </strong>broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>