D8476: qPort to new connect api + use const'ref

Laurent Montel noreply at phabricator.kde.org
Wed Oct 25 16:19:47 UTC 2017


mlaurent added inline comments.

INLINE COMMENTS

> broulik wrote in foldermodel.h:256
> Did you check whether QML can cope with `const &`? The `urls` is used in an `onMove` QML handler (I recall it not handling `const *` well)

I didn't see an error here, but perhaps I didn't test action which use this signal.
To be safe I will exclude this part of patch until I am sure that it's ok.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8476

To: mlaurent, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171025/b4677f68/attachment.html>


More information about the Plasma-devel mailing list