D8758: Support modifier+mouse button on window decoration

David Edmundson noreply at phabricator.kde.org
Sun Nov 12 21:58:19 UTC 2017


davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  ship it, but I have a question

INLINE COMMENTS

> input.cpp:960
> +
> +std::pair<bool, bool> performClientWheelAction(QWheelEvent *event, AbstractClient *c, MouseAction action = MouseAction::ModifierOnly)
> +{

if we're always going to do:

  if (actionResult.first) {
      return actionResult.second;

why return two bools and not just "and" them here?

REPOSITORY
  R108 KWin

BRANCH
  decoration-alt-button-5.11

REVISION DETAIL
  https://phabricator.kde.org/D8758

To: graesslin, #kwin, #plasma, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171112/d81f9d40/attachment.html>


More information about the Plasma-devel mailing list