<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8758" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>ship it, but I have a question</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8758#inline-38699" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">input.cpp:960</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">std</span><span style="color: #aa2211">::</span><span class="n">pair</span><span style="color: #aa2211"><</span><span style="color: #aa4000">bool</span><span class="p">,</span> <span style="color: #aa4000">bool</span><span style="color: #aa2211">></span> <span class="n">performClientWheelAction</span><span class="p">(</span><span class="n">QWheelEvent</span> <span style="color: #aa2211">*</span><span class="n">event</span><span class="p">,</span> <span class="n">AbstractClient</span> <span style="color: #aa2211">*</span><span class="n">c</span><span class="p">,</span> <span class="n">MouseAction</span> <span class="n">action</span> <span style="color: #aa2211">=</span> <span class="n">MouseAction</span><span style="color: #aa2211">::</span><span class="n">ModifierOnly</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">if we're always going to do:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if (actionResult.first) {
    return actionResult.second;</pre></div>

<p style="padding: 0; margin: 8px;">why return two bools and not just "and" them here?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>decoration-alt-button-5.11</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8758" rel="noreferrer">https://phabricator.kde.org/D8758</a></div></div><br /><div><strong>To: </strong>graesslin, KWin, Plasma, broulik, davidedmundson<br /><strong>Cc: </strong>davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>