D8758: Support modifier+mouse button on window decoration
Martin Flöser
noreply at phabricator.kde.org
Mon Nov 13 16:25:50 UTC 2017
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in input.cpp:960
> if we're always going to do:
>
> if (actionResult.first) {
> return actionResult.second;
>
> why return two bools and not just "and" them here?
if actionResult.first is true we should not further process and return the result of actionResult.second. If actionResult.second is false we don't know anymore what the result of actionResult.first was if we and them.
REPOSITORY
R108 KWin
BRANCH
decoration-alt-button-5.11
REVISION DETAIL
https://phabricator.kde.org/D8758
To: graesslin, #kwin, #plasma, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171113/1e9af7e0/attachment.html>
More information about the Plasma-devel
mailing list