D8493: Make Folder View screen aware
Andras Mantia
noreply at phabricator.kde.org
Fri Nov 3 14:29:16 UTC 2017
amantia updated this revision to Diff 21837.
amantia added a comment.
- add unit tests for different scenarios of foldermodel and screenmapper usage on multiple screens
- connect screenMappingChanged to invalidateFilter
- as addMapping is called from withing filterAcceptRows, make it possible to emit screenMappingChanged in a delayed way and compressed to avoid
multiple and recursive calls to filterAcceptRows
- do not call invalidateFilter from setScreen as it is called via screensChanged
- store firstscreen usage per configured folderview path. This is needed if the two screens are configured to show different folders. There is a
unit test for it, but needs to be tested also visually (quick test shows some problems I need to debug before this is accepted).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=21711&id=21837
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8493
AFFECTED FILES
containments/desktop/package/contents/config/main.xml
containments/desktop/package/contents/ui/FolderView.qml
containments/desktop/package/contents/ui/FolderViewLayer.qml
containments/desktop/plugins/folder/CMakeLists.txt
containments/desktop/plugins/folder/autotests/CMakeLists.txt
containments/desktop/plugins/folder/autotests/foldermodeltest.cpp
containments/desktop/plugins/folder/autotests/foldermodeltest.h
containments/desktop/plugins/folder/autotests/screenmappertest.cpp
containments/desktop/plugins/folder/autotests/screenmappertest.h
containments/desktop/plugins/folder/foldermodel.cpp
containments/desktop/plugins/folder/foldermodel.h
containments/desktop/plugins/folder/folderplugin.cpp
containments/desktop/plugins/folder/screenmapper.cpp
containments/desktop/plugins/folder/screenmapper.h
To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, mwolff
Cc: ngraham, mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171103/6595251f/attachment.html>
More information about the Plasma-devel
mailing list