D8493: Make Folder View screen aware

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> foldermodel.cpp:535
> +        m_screenMapper->addScreen(screen);
> +        invalidateFilter();
> +    }

this should not be required, since `addScreen` calls `screensChanged` and that is connected to `invalidateFilter` already.

> foldermodel.cpp:1678
> +    if (m_screenMapper) {
> +        connect(m_screenMapper, &ScreenMapper::screensChanged, this, &FolderModel::invalidateFilter);
> +    }

this should also connect to `screenMappingChanged`. Once we handle DND across views, we will update the mapping to point to a different screen. As a reaction, both `FolderModel` instances (source and target of the DND action) need to update their filter. The easiest is via this signal.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8493

To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, mwolff
Cc: ngraham, mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171102/0e956315/attachment-0001.html>