<table><tr><td style="">amantia updated this revision to Diff 21837.<br />amantia added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8493" rel="noreferrer">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">add unit tests for different scenarios of foldermodel and screenmapper usage on multiple screens</li>
<li class="remarkup-list-item">connect screenMappingChanged to invalidateFilter</li>
<li class="remarkup-list-item">as addMapping is called from withing filterAcceptRows, make it possible to emit screenMappingChanged in a delayed way and compressed to avoid</li>
</ul>

<p>multiple and recursive calls to filterAcceptRows</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">do not call invalidateFilter from setScreen as it is called via screensChanged</li>
<li class="remarkup-list-item">store firstscreen usage per configured folderview path. This is needed if the two screens are configured to show different folders. There is a</li>
</ul>

<p>unit test for it, but needs to be tested also visually (quick test shows some problems I need to debug before this is accepted).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D8493?vs=21711&id=21837" rel="noreferrer">https://phabricator.kde.org/D8493?vs=21711&id=21837</a></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8493" rel="noreferrer">https://phabricator.kde.org/D8493</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>containments/desktop/package/contents/config/main.xml<br />
containments/desktop/package/contents/ui/FolderView.qml<br />
containments/desktop/package/contents/ui/FolderViewLayer.qml<br />
containments/desktop/plugins/folder/CMakeLists.txt<br />
containments/desktop/plugins/folder/autotests/CMakeLists.txt<br />
containments/desktop/plugins/folder/autotests/foldermodeltest.cpp<br />
containments/desktop/plugins/folder/autotests/foldermodeltest.h<br />
containments/desktop/plugins/folder/autotests/screenmappertest.cpp<br />
containments/desktop/plugins/folder/autotests/screenmappertest.h<br />
containments/desktop/plugins/folder/foldermodel.cpp<br />
containments/desktop/plugins/folder/foldermodel.h<br />
containments/desktop/plugins/folder/folderplugin.cpp<br />
containments/desktop/plugins/folder/screenmapper.cpp<br />
containments/desktop/plugins/folder/screenmapper.h</div></div></div><br /><div><strong>To: </strong>amantia, Plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol, mwolff<br /><strong>Cc: </strong>ngraham, mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>