D5144: Change the volume icon/mute button into a ToolButton

[David Rosca]

drosca added a comment.


  > The "hack" is consistent with the one of context menu button.
  
  It's not, context menu button have spacing
  
  > I think the improved discoverability outweighs your objections. We can use this here until someone diggs deeper and improves ToolButton in this regard.
  
  If we go with this, it must be moved into a separate item, let's say SmallToolButton.qml
  
  > @Zren: Can you tell me why your icon looks different from mine and why on my I still have a small (and nice) margin:
  
  Because you use scaling and 22px version of the icon has bigger margins.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D5144

To: Zren, #plasma, subdiff, drosca
Cc: subdiff, drosca, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170323/53d92fab/attachment.html>