D5144: Change the volume icon/mute button into a ToolButton

Roman Gilg noreply at phabricator.kde.org
Thu Mar 23 11:57:32 UTC 2017


subdiff added a comment.


  > I don't like it, the context menu button is enough hacks for one applet.
  
  The "hack" is consistent with the one of context menu button.
  
  I think the improved discoverability outweighs your objections. We can use this here until someone diggs deeper and improves ToolButton in this regard.
  
  @Zren: Can you tell me why your icon looks different from mine and why on my I still have a small (and nice) margin:
  F3149213: tempmicro.png <https://phabricator.kde.org/F3149213>

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D5144

To: Zren, #plasma, subdiff, drosca
Cc: subdiff, drosca, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170323/e27c3960/attachment.html>


More information about the Plasma-devel mailing list