D6186: Implement software cursor in OpenGL backend

Oleg Chernovskiy noreply at phabricator.kde.org
Mon Jun 19 07:25:32 UTC 2017


Kanedias added inline comments.

INLINE COMMENTS

> luebking wrote in scene_opengl.cpp:713
> You still update the cursor texture with every paint() - there should be no need to hook this signal.
> Actually, the patch got much worse:
> 
> a) you're fetching the image and reset the texture with each! paint()
> b) you're creating a nerw connection to cursorChanged() with each! paint()

How come! There's a condition on !m_cursorTexture for that, no? Or is Cursor::cursorChanged itself called on every paint?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6186

To: Kanedias, graesslin, davidedmundson
Cc: luebking, plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170619/bcb6ff88/attachment.html>


More information about the Plasma-devel mailing list