D6186: Implement software cursor in OpenGL backend

[Thomas Lübking]

luebking added inline comments.

INLINE COMMENTS

> scene_opengl.cpp:713
> +        // handle shape update on case cursor image changed
> +        connect(Cursor::self(), &Cursor::cursorChanged, this, updateCursorTexture);
> +    }

You still update the cursor texture with every paint() - there should be no need to hook this signal.
Actually, the patch got much worse:

a) you're fetching the image and reset the texture with each! paint()
b) you're creating a nerw connection to cursorChanged() with each! paint()

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6186

To: Kanedias, graesslin, davidedmundson
Cc: luebking, plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170619/bf96464b/attachment.html>