D6938: [Folder View Config] Make model writable and drop custom setRowChecked method
Kai Uwe Broulik
noreply at phabricator.kde.org
Wed Jul 26 15:48:36 UTC 2017
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
By implementing `setData` we make the `model` magic property writable and can directly assign `model.checked` a new value.
Not only is this cleaner but it will just work with proxy models.
TEST PLAN
Changed some preview plugins, applied settings, preview plugins were loaded/unloaded as desired.
Changed some mimetype filters, applied settings, files showed up anddisappeared as desired.
(The FilterableMimeTypesModel can probably be removed and replaced by a Plasma SortFilterModel)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6938
AFFECTED FILES
containments/desktop/package/contents/ui/ConfigFilter.qml
containments/desktop/package/contents/ui/FolderItemPreviewPluginsDialog.qml
containments/desktop/plugins/folder/mimetypesmodel.cpp
containments/desktop/plugins/folder/mimetypesmodel.h
containments/desktop/plugins/folder/previewpluginsmodel.cpp
containments/desktop/plugins/folder/previewpluginsmodel.h
To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170726/35f36a50/attachment.html>
More information about the Plasma-devel
mailing list