<table><tr><td style="">broulik created this revision.<br />Restricted Application added a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6938" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>By implementing <tt style="background: #ebebeb; font-size: 13px;">setData</tt> we make the <tt style="background: #ebebeb; font-size: 13px;">model</tt> magic property writable and can directly assign <tt style="background: #ebebeb; font-size: 13px;">model.checked</tt> a new value.<br />
Not only is this cleaner but it will just work with proxy models.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Changed some preview plugins, applied settings, preview plugins were loaded/unloaded as desired.<br />
Changed some mimetype filters, applied settings, files showed up anddisappeared as desired.</p>

<p>(The FilterableMimeTypesModel can probably be removed and replaced by a Plasma SortFilterModel)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6938" rel="noreferrer">https://phabricator.kde.org/D6938</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>containments/desktop/package/contents/ui/ConfigFilter.qml<br />
containments/desktop/package/contents/ui/FolderItemPreviewPluginsDialog.qml<br />
containments/desktop/plugins/folder/mimetypesmodel.cpp<br />
containments/desktop/plugins/folder/mimetypesmodel.h<br />
containments/desktop/plugins/folder/previewpluginsmodel.cpp<br />
containments/desktop/plugins/folder/previewpluginsmodel.h</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, hein<br /><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>