D6938: [Folder View Config] Make model writable and drop custom setRowChecked method

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Jul 26 15:52:53 UTC 2017


broulik updated this revision to Diff 17242.
broulik added a comment.


  Emit checkedTypesChanged only when changed, I hoped model would be smart enough not to change if the value was the same but implicit assignment always ends up in setData

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6938?vs=17241&id=17242

REVISION DETAIL
  https://phabricator.kde.org/D6938

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigFilter.qml
  containments/desktop/package/contents/ui/FolderItemPreviewPluginsDialog.qml
  containments/desktop/plugins/folder/mimetypesmodel.cpp
  containments/desktop/plugins/folder/mimetypesmodel.h
  containments/desktop/plugins/folder/previewpluginsmodel.cpp
  containments/desktop/plugins/folder/previewpluginsmodel.h

To: broulik, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170726/b8655dac/attachment-0001.html>


More information about the Plasma-devel mailing list