[Differential] [Changed Subscribers] D4241: Support modifier-only-shortcuts when capslock is on

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> modifier_only_shortcut_test.cpp:281
>      // currently caps lock is on
> -    // shift is ignored
> +    // shift still triggers
>      kwinApp()->platform()->keyboardKeyPressed(modifier, timestamp++);

I don't get this change:

This is the " // this test verifies that Capslock does not trigger the shift shortcut" part of the test.

Shift has been released on line 276, so triggeredSpy shouldn't be going up.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4241

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: davidedmundson, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170124/d4452dca/attachment.html>