[Differential] [Commented On] D4241: Support modifier-only-shortcuts when capslock is on

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in modifier_only_shortcut_test.cpp:281
> I don't get this change:
> 
> This is the " // this test verifies that Capslock does not trigger the shift shortcut" part of the test.
> 
> Shift has been released on line 276, so triggeredSpy shouldn't be going up.

No, it is the capslock key which got released in 276. So at that point here capslock is on, typing an a would result in A.

So far when that was the case pressing shift did not trigger the modifier only shortcut, now it does.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4241

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: davidedmundson, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170125/0c0ad96f/attachment.html>