[Differential] [Commented On] D3982: [Panel Containment] Correctly compare applets without order

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> LayoutManager.js:42
>              return -1
> +        } else if (aIdx === -1 && bIdx === -1) {
> +            // if both don't have an order yet (fresh config), look up their relative position within "applets"

FWIW, if we go back to this, you can just return 0 here.

"If compareFunction(a, b) returns 0, leave a and b unchanged with respect to each other"

JS sort seems like Qt's stableSort

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3982

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170105/b4018b7a/attachment-0001.html>