[Differential] [Updated] D3982: [Panel Containment] Correctly compare applets without order

davidedmundson (David Edmundson) noreply at phabricator.kde.org
Thu Jan 5 15:38:56 UTC 2017


davidedmundson added a comment.


  Edit, I was wrong about my earlier comment, and found your bug too.
  
  You can't reference applets whilst you're sorting applets.
  
    } else if (aIdx === -1 && bIdx === -1) {
             // if both don't have an order yet (fresh config), look up their relative position within "applets"
             return plasmoid.applets.indexOf(a) - plasmoid.applets.indexOf(b);
         }
  
  works.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3982

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170105/6a12211b/attachment.html>


More information about the Plasma-devel mailing list