[Differential] [Request, 3 lines] D3982: [Panel Containment] Correctly compare applets without order

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Thu Jan 5 15:07:34 UTC 2017


broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When comparing two applets that don't have an order yet, we would fall through to the regular sorting algorithm which would return "(-1) - (-1)", ie. -2 and then add the applets the wrong way round.
  
  This happens when adding a new default panel. Instead, take into account the relative order within "plasmoid.applets"

TEST PLAN
  Added new default panel, order is correct.
  Verified that applets not in AppletOrder will still be sorted last as before
  
  Fixes regression introduced in https://phabricator.kde.org/D3834

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3982

AFFECTED FILES
  containments/panel/contents/code/LayoutManager.js

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170105/a9854df4/attachment-0001.html>


More information about the Plasma-devel mailing list