D9271: Fixed memory leak in new_argv

Nathan Henry noreply at phabricator.kde.org
Tue Dec 12 22:31:46 UTC 2017


nathanhenry added inline comments.

INLINE COMMENTS

> davidedmundson wrote in Viewer.cpp:145
> and then it will crash here.

Should this be dereferenced outside the loop or not at all?

> davidedmundson wrote in kcm.cpp:83-85
> The runner manager has a parent object.
> 
> http://doc.qt.io/qt-5/objecttrees.html

Thanks

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9271

To: nathanhenry, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171212/aaf6bfb0/attachment-0001.html>


More information about the Plasma-devel mailing list