D9271: Fixed memory leak in new_argv

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> nathanhenry wrote in Viewer.cpp:140-143
> More info?

you're deleting an object immediately after show.

That will close the dialog

> Viewer.cpp:145
>                  }
>                  viewer->showUrl(url);
> +		delete viewer;

and then it will crash here.

> nathanhenry wrote in kcm.cpp:83-85
> How doesn't this leak when excluding my change?

The runner manager has a parent object.

http://doc.qt.io/qt-5/objecttrees.html

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9271

To: nathanhenry, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171212/3b7141b8/attachment.html>