D7248: Microoptimise: don't change fillMode of image just before deleting itIt is still set for when a source is applied for the next transistion.

[David Edmundson]

davidedmundson added a comment.


  To expand on the crash:
  
  Killer line is
  
  fadeAnim.running = Qt.binding(function() {
  
        return currentImage.status !== Image.Loading && otherImage.status !== Image.Loading
    })
  
  the idea being to delay the loading until both things are loaded.
  
  But scriptAnimation at the end does:
  
  otherImage.fillMode = fillMode;
  otherImage.source = "";
  
  which means from inside the animation we change fillMode - running goes to false as it reloads the image with the new fillMode (asynchronously)
  then we unset the source, running goes to true as it's no longer loading
  
  We're completely restarting the animation from within the animation. 
  Qt doesn't like that.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7248

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170811/dc799279/attachment.html>