D7248: Microoptimise: don't change fillMode of image just before deleting itIt is still set for when a source is applied for the next transistion.

[David Edmundson]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This saves evaluating a new paintedSize and doing a bunch of evaluations
  for no reason.
  
  More importantly it works round a Qt animation crash.
  
  CCBUG: 381105

TEST PLAN
  Cloned this code whilst making a tiny reproducible test case
  Found swapping these lines made that go away
  Given it results in less processing we may as well do it.
  
  End user result is the same.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7248

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170811/9195bf63/attachment.html>