[Differential] [Commented On] D2671: Reduce duplicated code and document very difficult to parse code.

davidedmundson (David Edmundson) noreply at phabricator.kde.org
Tue Sep 6 08:44:43 UTC 2016


davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in Panel.qml:97
> why real? You cannot (should not) have half pixels

There's a Math.round in the usage below, and FrameMargins can also be real, so it's still needed there.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2671

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160906/0c7d2a3b/attachment.html>


More information about the Plasma-devel mailing list