[Differential] [Changed Subscribers] D2671: Reduce duplicated code and document very difficult to parse code.
broulik (Kai Uwe Broulik)
noreply at phabricator.kde.org
Tue Sep 6 08:41:27 UTC 2016
broulik added inline comments.
INLINE COMMENTS
> Panel.qml:97
> + //the size a margin should be to force a panel to be the required size above
> + readonly property real spacingAtMinSize: Math.max(1, (verticalPanel ? root.width : root.height) - units.iconSizes.smallMedium - units.smallSpacing*2)/2
> +
why real? You cannot (should not) have half pixels
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2671
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160906/039e7f40/attachment.html>
More information about the Plasma-devel
mailing list