[Differential] [Accepted] D2671: Reduce duplicated code and document very difficult to parse code.
mart (Marco Martin)
noreply at phabricator.kde.org
Tue Sep 6 09:04:44 UTC 2016
mart accepted this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> davidedmundson wrote in Panel.qml:97
> There's a Math.round in the usage below, and FrameMargins can also be real, so it's still needed there.
given that we round the value everywhere actually used, either is fine
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2671
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, mart
Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160906/6f752bde/attachment.html>
More information about the Plasma-devel
mailing list