[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL

[luebking (Thomas Lübking)]

luebking added inline comments.

INLINE COMMENTS

> graesslin wrote in composite.cpp:748
> this misses the
> 
>   if (m_scene->compositingType() & OpenGLCompositing)

also indention.

> x11_platform.cpp:206
> +        // Deliberately continue with PreFrame
> +    case OpenGLSafePoint::PreFrame:
> +        if (m_openGLFreezeProtectionThread == nullptr) {

PreFrame is (now) effectively "PreFirstGuardedFrame", is it?
And if invoked at some later point would create the timer and hit the config rewrite every single frame (for the counter is stuck at 0)?

> rename to avoid bad invocation?
=================================

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3132

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antlarr, #kwin, #plasma, davidedmundson
Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161024/16e0959c/attachment-0001.html>