[Differential] [Commented On] D3132: [platformx/x11] Add a freeze protection against OpenGL

[graesslin (Martin Gräßlin)]

graesslin added inline comments.

INLINE COMMENTS

> composite.cpp:748
> +        m_framesToTestForSafety--;
> +	if (m_framesToTestForSafety == 0) {
> +            kwinApp()->platform()->createOpenGLSafePoint(Platform::OpenGLSafePoint::PostLastGuardedFrame);

this misses the

  if (m_scene->compositingType() & OpenGLCompositing)

> x11_platform.cpp:225-227
> +        }
> +        else
> +        {

nitpick: coding style

  } else {

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3132

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antlarr, #kwin, #plasma, davidedmundson
Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20161024/4fa0048f/attachment.html>